[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] Availability of Release Candidate 3 for 1.0.0



On 10/31/2012 06:29 AM, Leonardo Arena wrote:
> Hi,
> 
> I was invited to show up here regarding BZ 871756. I'm the maintainer of
> libvirt on Alpine Linux [1], an uclibc-based distro.
> 
> If you need more info, testing, etc. just let me know.

> --- a/src/util/logging.c
> +++ b/src/util/logging.c
> @@ -58,6 +58,11 @@
>  
>  #define VIR_FROM_THIS VIR_FROM_NONE
>  
> +#ifdef __UCLIBC__
> +/* uclibc does not implement mkostemp GNU extention */
> +#define mkostemp(x,y) mkstemp(x)
> +#endif
> +
>  VIR_ENUM_DECL(virLogSource)
>  VIR_ENUM_IMPL(virLogSource, VIR_LOG_FROM_LAST,
>                "file",

NACK.  Rather, we should be using gnulib's mkostemp - I'm working on the
patch, and will post it shortly.  If you could test my version, that
would be much appreciated.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]