[libvirt] [PATCH] Don't assume pid_t is the same size as an int

Eric Blake eblake at redhat.com
Wed Oct 31 20:23:09 UTC 2012


On 10/31/2012 11:02 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange at redhat.com>
> 
> virPidFileReadPathIfAlive passed in an 'int *' where a 'pid_t *'
> was expected, which breaks on Mingw64 targets. Also a few places
> were using '%d' for formatting pid_t, change them to '%lld' and
> force a cast to the longer type as done elsewhere in the same
> file.
> 
> Signed-off-by: Daniel P. Berrange <berrange at redhat.com>
> ---
>  src/util/virpidfile.c |  4 ++--
>  src/util/virprocess.c | 13 +++++++------
>  2 files changed, 9 insertions(+), 8 deletions(-)

ACK.

-- 
Eric Blake   eblake at redhat.com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 617 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20121031/2759db1a/attachment-0001.sig>


More information about the libvir-list mailing list