[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 06/20] snapshot: Add flag to enable creating checkpoints in paused state



On 10/31/2012 04:12 PM, Eric Blake wrote:
> On 10/23/2012 09:12 AM, Peter Krempa wrote:
>> The default behavior while creating external checkpoints is to let the
>> guest run while the memory state is caputred. This leads to a larger
>> save file but minimizes the time needed to take the checkpoint.
>>
>> This patch adds a flag that causes the guest to be paused before taking
>> the snapshot.
> 
> For this patch, I'm going to review the updated version at
>  git fetch git://pipo.sk/pipo/libvirt.git snap-revert
> 
>>     This patch adds a flag that causes the guest not to be paused before
>>     taking the snapshot.
>>      *include/libvirt/libvirt.h.in:
>>         - add new paused reason: VIR_DOMAIN_PAUSED_SNAPSHOT
>>         - add new flag for takin snapshot: VIR_DOMAIN_SNAPSHOT_CREATE_LIVE
> 
> s/takin/taking/
> 
>>      *tools/virsh-domain-monitor.c:
>>         - add string representation for VIR_DOMAIN_PAUSED_SNAPSHOT
>>      *tools/virsh-snapshot.c:
>>         - add support for VIR_DOMAIN_SNAPSHOT_CREATE_LIVE
>>      *tools/virsh.pod:
>>         - add docs for --live option added to use
>>         VIR_DOMAIN_SNAPSHOT_CREATE_LIVE flag
> 
> This misses examples/domain-events/events-c/event-test.c, which also
> needs updates.

Also, this missed a mention of the new flag in src/libvirt.c.

> Should we also mention that it is not supported with internal
> checkpoint, and/or mention that it is silently ignored for offline
> snapshots?

The fact that _LIVE and internal snapshots don't mix is a qemu
limitation, but not a limitation inherent in the API as available in
src/libvirt.c, so it will be interesting to see how you word things.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]