[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH V4] implement offline migration



On Mon, Sep 03, 2012 at 02:23:24PM +0800, liguang wrote:
> allow migration even domain isn't active by
> inserting some stubs to tunnel migration path.
> 
> Signed-off-by: liguang <lig fnst cn fujitsu com>
> ---
>  src/qemu/qemu_driver.c    |    2 +-
>  src/qemu/qemu_migration.c |  181
> +++++++++++++++++++++++++++++++++++++++++++--
>  src/qemu/qemu_migration.h |    3 +-
>  3 files changed, 178 insertions(+), 8 deletions(-)

I really don't like the general design of this patch, even
ignoring all the code bugs. I think this entire patch is
really just a solution in search of a problem. Offline migration
is already possible with existing libvirt APIs:

   domsrc = virDomainLookupByName(connsrc, "someguest");
   xml = virDomainGetXMLDesc(domsrc);
   domdst virDomainDefine(conndst, xml);

This proposed patch does not offer enough (or indeed any) compelling
benefit over the above, to make it worth the including these hacks.

NACK to the entire patch.

Daniel.
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]