[libvirt] [PATCH] Rename iolimit to blockio.
Eric Blake
eblake at redhat.com
Tue Sep 4 14:56:06 UTC 2012
On 09/04/2012 08:30 AM, Viktor Mihajlovski wrote:
> After discussion with DB we decided to rename the new iolimit
> element as it creates the impression it would be there to
> limit (i.e. throttle) I/O instead of specifying immutable
> characteristics of a block device.
> This is also backed by the fact that the term I/O Limits has
> vanished from newer storage admin documentation.
>
> Signed-off-by: Viktor Mihajlovski <mihajlov at linux.vnet.ibm.com>
> ---
> docs/formatdomain.html.in | 6 ++--
> docs/schemas/domaincommon.rng | 6 ++--
> src/conf/domain_conf.c | 30 +++++++++---------
> src/conf/domain_conf.h | 2 +-
> src/qemu/qemu_capabilities.c | 4 +-
> src/qemu/qemu_capabilities.h | 2 +-
> src/qemu/qemu_command.c | 10 +++---
> tests/qemuhelptest.c | 8 ++--
> .../qemuxml2argv-disk-blockio.args | 9 +++++
> .../qemuxml2argvdata/qemuxml2argv-disk-blockio.xml | 33 ++++++++++++++++++++
> .../qemuxml2argv-disk-iolimits.args | 9 -----
> .../qemuxml2argv-disk-iolimits.xml | 33 --------------------
> tests/qemuxml2argvtest.c | 4 +-
> 13 files changed, 78 insertions(+), 78 deletions(-)
> create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-blockio.args
> create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-blockio.xml
> delete mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-iolimits.args
> delete mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-iolimits.xml
Your diff would be smaller if you used 'git config diff.renames true',
as it would then show file renames instead of delete/create actions.
But that's only in the presentation, and not a flaw in the patch itself.
ACK and will push shortly.
> +++ b/src/qemu/qemu_capabilities.c
> @@ -172,7 +172,7 @@ VIR_ENUM_IMPL(qemuCaps, QEMU_CAPS_LAST,
> "bridge", /* 100 */
> "lsi",
> "virtio-scsi-pci",
> - "iolimits",
> + "blockio",
> "disable-s3",
This hunk will invalidate any running domains that were started with
libvirt.git after the original patch but prior to applying this patch;
but since that is unreleased code, I think anyone affected will be
reading this list, so I'm not worried about it.
--
Eric Blake eblake at redhat.com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 617 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20120904/8b142340/attachment-0001.sig>
More information about the libvir-list
mailing list