[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] [trivial] Fix spelling mistake



On 09/05/2012 08:49 AM, Philipp Hahn wrote:
> provably -> probably
> 
> Signed-off-by: Philipp Hahn <hahn univention de>
> ---
>  cfg.mk          |    2 +-
>  src/libvirt.c   |    2 +-
>  tools/virsh.pod |    2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/cfg.mk b/cfg.mk
> index 4cdfd1b..8fd9462 100644
> --- a/cfg.mk
> +++ b/cfg.mk
> @@ -379,7 +379,7 @@ sc_prohibit_setuid:
>  	halt='use virSetUIDGID, not raw set*id'				\
>  	  $(_sc_search_regexp)
>  
> -# Use snprintf rather than s'printf, even if buffer is provably large enough,
> +# Use snprintf rather than s'printf, even if buffer is probably large enough,

NACK.  In this case, we meant 'provably', as in we can provide formal
mathematical proof of the property.

>  # since gnulib has more guarantees for snprintf portability
>  sc_prohibit_sprintf:
>  	@prohibit='\<[s]printf\>'					\
> diff --git a/src/libvirt.c b/src/libvirt.c
> index b034ed6..041e4a6 100644
> --- a/src/libvirt.c
> +++ b/src/libvirt.c
> @@ -17968,7 +17968,7 @@ error:
>   * new hypervisor instance rather than reusing the existing hypervisor
>   * (since this would terminate all connections to the domain, such as
>   * such as VNC or Spice graphics) - this condition arises from active
> - * snapshots that are provably ABI incomaptible, as well as from
> + * snapshots that are probably ABI incomaptible, as well as from
>   * inactive snapshots with a @flags request to start the domain after
>   * the revert.

Same NACK - we can prove whether a request is ABI incompatible.

>   *
> diff --git a/tools/virsh.pod b/tools/virsh.pod
> index a26c420..36b9593 100644
> --- a/tools/virsh.pod
> +++ b/tools/virsh.pod
> @@ -2685,7 +2685,7 @@ the case of reverting from a running domain to an active state where a
>  new hypervisor has to be created rather than reusing the existing
>  hypervisor, because it implies drawbacks such as breaking any existing
>  VNC or Spice connections; this condition happens with an active
> -snapshot that uses a provably incompatible configuration, as well as
> +snapshot that uses a probably incompatible configuration, as well as

Same NACK - we can prove whether a configuration is compatible.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]