[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [RFC PATCH v1 1/2] Qemu/Gluster: Add Gluster protocol as supported network disk formats.



On Wed, Sep 5, 2012 at 7:03 PM, Jiri Denemark <jdenemar redhat com> wrote:
>> @@ -1042,6 +1043,13 @@
>>                      <attribute name="port">
>>                        <ref name="unsignedInt"/>
>>                      </attribute>
>> +                    <attribute name="transport">
>> +                      <choice>
>> +                        <value>socket</value>
>> +                        <value>unix</value>
>> +                        <value>rdma</value>
>
> This could be a bit confusing as socket is too generic, after all unix is also
> a socket. Could we change the values "tcp", "unix", "rdma" or something
> similar depending on what "socket" was supposed to mean?

That is how gluster calls it and hence I am using the same in QEMU and
the same is true here too. This is something for gluster developers to
decide if they want to change socket to something more specific like
tcp as you suggest.

Regards,
Bharata.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]