[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/5] list: Define new API virConnectListAllNWFilters



On 09/05/2012 12:02 AM, Osier Yang wrote:
> This is to list the network fitler objects. No flags are supported

s/fitler/filter/


>  
> +/**
> + * virConnectListAllNWFilters:
> + * @conn: Pointer to the hypervisor connection.
> + * @filters: Pointer to a variable to store the array containing the network
> + *           filter objects or NULL if the list is not required (just returns
> + *           number of network filters).
> + * @flags: extra flags; not used yet, so callers should always pass 0
> + *
> + * Collect the list of network filters, and allocate an array to store those
> + * objects.

Maybe it's worth filtering on whether a filter is just references to
other filters, contains rules, or contains both.  But for that to be
useful, it would also be nice to have an API where, given an individual
virNWFilterPtr, we can then return a list of all other virNWFilterPtr
that were pulled in by reference (that is, similar to snapshots, have an
API sufficiently powerful to reconstruct the tree of filter references).
 So I'm okay with this version going in with no flag support for now.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]