[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv3 0/4] Add range checking for scheduler tunables



On 09/06/2012 08:01 AM, Peter Krempa wrote:
> This version improves virsh so that it doesn't update all tunables
> but only those that changed (and now correctly).
> 
> This series contains a new patch that adds a helper to deal
> with typed parameters.
> 
> Regarding typed parameters: Shouldn't we make the helpers to deal
> with them public?
> 
> (Patches 1 and 2 didn't change to v2)

Technically, the commit message of 1 changed, but for the better; and
you folded in my LL hint in commit 2.

> 
> Peter Krempa (4):
>   qemu: clean up qemuSetSchedulerParametersFlags()
>   qemu: Add range checking for scheduler tunables when changed by API
>   util: Add helper to assign typed params from string
>   virsh: Update only changed scheduler tunables

ACK series, with nit in 3 fixed.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]