[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 4/4] examples: Fix event detail printing in python test



On Thu, Sep 6, 2012 at 10:09 AM, Jiri Denemark <jdenemar redhat com> wrote:
> If there is only one detail string for a particular event, we need to pu
> comma after the string otherwise the string itself will be taken as a
> list and only its first character will be printed out. For example,
>
>     myDomainEventCallback1 EVENT: Domain fedora17(12) Shutdown F
>
> instead of the desired
>
>     myDomainEventCallback1 EVENT: Domain fedora17(12) Shutdown Finished
> ---
>  examples/domain-events/events-python/event-test.py | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/examples/domain-events/events-python/event-test.py b/examples/domain-events/events-python/event-test.py
> index fd71acd..3e314bf 100644
> --- a/examples/domain-events/events-python/event-test.py
> +++ b/examples/domain-events/events-python/event-test.py
> @@ -443,12 +443,12 @@ def eventToString(event):
>  def detailToString(event, detail):
>      eventStrings = (
>          ( "Added", "Updated" ),
> -        ( "Removed" ),
> +        ( "Removed", ),
>          ( "Booted", "Migrated", "Restored", "Snapshot", "Wakeup" ),
>          ( "Paused", "Migrated", "IOError", "Watchdog", "Restored", "Snapshot" ),
>          ( "Unpaused", "Migrated", "Snapshot" ),
>          ( "Shutdown", "Destroyed", "Crashed", "Migrated", "Saved", "Failed", "Snapshot"),
> -        ( "Finished" )
> +        ( "Finished", ),
>          ( "Memory", )
>          )
>      return eventStrings[event][detail]
> --
> 1.7.12

ACK.

-- 
Doug Goldstein


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]