[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] remove dnsmasq command line parameter "--filterwin2k"

On 09/06/2012 01:54 PM, Gene Czarcinski wrote:
> On 09/06/2012 01:00 PM, Eric Blake wrote:
>> On 09/06/2012 10:08 AM, Gene Czarcinski wrote:
>>>    This patch removed the "--filterwin2k" dnsmasq command line
>>>    parameter which was unnecessary for domain specification,
>>>    possibly blocked some usage, and was command line clutter.
>>>    Gene Czarcinski <gene czarc net>
>> ACK and pushed.  'git am' didn't like the mail (it came through with
>> horrible whitespace corruption), so I had to hand-apply the entire patch
>> (manual tweak of bridge-driver.c, then a sed script to touch up the 9
>> test files), but I don't mind helping out on a first message while you
>> are still learning git.  But expect a request for a repost if this
>> happens on future patches :)
> I expect the the problem must be that I am using thunderbird as my
> regular email client.  Now that I have more info about  using "git
> send-email", maybe next time will be better.

Yes, Thunderbird does a very bad job of not mangling patches up. I've
tried everything I can find and haven't found anything that makes it better.

> I am sorry that this caused you more work.  I thought about attaching
> the patch but the hacker document specifically requested inline and
> attached patches.

Heh. Yeah, I noticed that when making the small changes to HACKING
yesterday. Despite what it says, though, when I find the need to send a
patch via Thunderbird for some reason, I go against the recommendations
of HACKING and send it as an attached file instead of in the body of the
message. That produces an undamaged patch at the other end and, with
Thunderbird at least, it's possible to make in "inline" reply to the
patch by selecting the entire patch prior to hitting reply - this moves
the patch into the body of the message (with quotes).

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]