[libvirt] [PATCH 4/5] Call virResetLastError in all virConnectOpen* functions

Daniel P. Berrange berrange at redhat.com
Mon Sep 10 15:50:14 UTC 2012


From: "Daniel P. Berrange" <berrange at redhat.com>

All public API functions must call virResetLastError to clear
out any previous error. The virConnectOpen* functions forgot
todo this.

Signed-off-by: Daniel P. Berrange <berrange at redhat.com>
---
 src/libvirt.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/libvirt.c b/src/libvirt.c
index b034ed6..31656dc 100644
--- a/src/libvirt.c
+++ b/src/libvirt.c
@@ -1329,6 +1329,7 @@ virConnectOpen (const char *name)
             goto error;
 
     VIR_DEBUG("name=%s", name);
+    virResetLastError();
     ret = do_open (name, NULL, 0);
     if (!ret)
         goto error;
@@ -1363,6 +1364,7 @@ virConnectOpenReadOnly(const char *name)
             goto error;
 
     VIR_DEBUG("name=%s", name);
+    virResetLastError();
     ret = do_open (name, NULL, VIR_CONNECT_RO);
     if (!ret)
         goto error;
@@ -1401,6 +1403,7 @@ virConnectOpenAuth(const char *name,
             goto error;
 
     VIR_DEBUG("name=%s, auth=%p, flags=%x", NULLSTR(name), auth, flags);
+    virResetLastError();
     ret = do_open (name, auth, flags);
     if (!ret)
         goto error;
-- 
1.7.11.2




More information about the libvir-list mailing list