[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 2/5] Print any exception that occurs in authentication callback



On 09/10/2012 09:50 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange redhat com>
> 
> If an exception occurs in the python callback for openAuth()
> the stack trace isn't seen by the apps, since this code is
> called from libvirt context. To aid diagnostics, print the
> error to stderr at least
> 
> Signed-off-by: Daniel P. Berrange <berrange redhat com>
> ---
>  python/libvirt-override.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)

Better than nothing.  I don't know the callstack here well enough to
know if we could eventually pass a NULL back to the outer python caller,
so that python could ultimately display a stacktrace, so for now, I'm
fine giving:

ACK.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]