[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 2/4] snapshot: improve disk align checking



On 09/11/2012 08:58 AM, Peter Krempa wrote:
> On 09/11/12 02:01, Eric Blake wrote:
>> There were not previous callers with require_match set to true.
> 
> s/not/no/
> 

>> +                 disk_snapshot == VIR_DOMAIN_SNAPSHOT_LOCATION_NONE))
>> +                disk->snapshot = disk_snapshot;
> 
> Uh, disk->snapshot and disk_snapshot are very easily confused for each
> other. But this issue is pre-existing.

Tell me about it.  I think I'll do a v2 that renames disk_snapshot in a
prereq patch.

> 
> ACK with nits fixed.

Again, I think I'll post a v2, if only to get the renaming done in advance.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]