[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 02/20] Wait to receive QMP greeting before sending any monitor commands



On 09/11/2012 05:26 PM, Eric Blake wrote:
> On 09/11/2012 08:11 AM, Daniel P. Berrange wrote:
>> From: "Daniel P. Berrange" <berrange redhat com>
>>
>> Technically speaking we should wait until we receive the QMP
>> greeting message before attempting to send any QMP monitor
>> commands. Mostly we've got away with this, but there is a race
>> in some QEMU which cause it to SEGV if you sent it data too
>> soon after startup. Waiting for the QMP greeting avoids the
>> race
>>
>> Signed-off-by: Daniel P. Berrange <berrange redhat com>
>> ---
>>  src/qemu/qemu_monitor.c | 9 ++++++++-
>>  1 file changed, 8 insertions(+), 1 deletion(-)
> 
> ACK.

Spoke too soon. This makes the testsuite hang in qemumonitorjsontest, as
the fake json monitor never manages to trigger the wait_greeting reset
to 0.  I'm not sure how best to fix the infloop, but that is needed
before this patch can go in.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]