[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH V6] support offline migration



在 2012-09-11二的 08:30 -0600,Eric Blake写道:

> 
> You either need to take care of migrating storage if the user does
> 'virsh migrate [whatever-we-decide-for-offline] --copy-storage-*', or
> else explicitly reject attempts to migrate storage in parallel with an
> offline migration.

right, I'll reject --copy-storage-* and error out.

> 
> > @@ -439,6 +441,11 @@ qemuMigrationCookieXMLFormat(struct qemud_driver *driver,
> >          virBufferAdjustIndent(buf, -2);
> >      }
> >  
> > +    if (mig->flags & QEMU_MIGRATION_COOKIE_OFFLINE) {
> > +        virBufferAsprintf(buf, "  <offline>\n");
> > +        virBufferAddLit(buf, "  </offline>\n");
> 
> Collapse these two lines into the simpler one-liner:
> 
> virBufferAddLit(buf, "  <offline/>\n");
> 

OK, I'll collapse them into one.

Thanks!

-- 
liguang    lig fnst cn fujitsu com
FNST linux kernel team



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]