[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 4/4] parallels: implement containers creation



On 120912 14:33:21, Daniel Veillard wrote:
> On Mon, Sep 10, 2012 at 07:22:45PM +0400, Dmitry Guryanov wrote:
> > Add separate function parallelsCreateCt, which creates container.
> > Also add example xml configuration domain-parallels-ct-simple.xml.
> > 
> > Signed-off-by: Dmitry Guryanov <dguryanov parallels com>
> > ---
> >  .gnulib                                            |    2 +-
> >  .../domain-parallels-ct-simple.xml                 |   28 ++++++++++++++++++++
> >  2 files changed, 29 insertions(+), 1 deletions(-)
> >  create mode 100644 tests/domainschemadata/domain-parallels-ct-simple.xml
> > 
> > diff --git a/.gnulib b/.gnulib
> > index 440a1db..271dd74 160000
> > --- a/.gnulib
> > +++ b/.gnulib
> > @@ -1 +1 @@
> > -Subproject commit 440a1dbe523e37f206252cb034c3a62f26867e42
> > +Subproject commit 271dd74fdf54ec2a03e73a5173b0b5697f6088f1
> 
>  NACK
> 
> > diff --git a/tests/domainschemadata/domain-parallels-ct-simple.xml b/tests/domainschemadata/domain-parallels-ct-simple.xml
> > new file mode 100644
> > index 0000000..f25721c
> > --- /dev/null
> > +++ b/tests/domainschemadata/domain-parallels-ct-simple.xml
> > @@ -0,0 +1,28 @@
> > +<domain type='parallels'>
> > +  <name>1010</name>
> > +  <uuid>88576506-d611-41c2-b6b6-c9043704a0dd</uuid>
> > +  <description></description>
> > +  <memory unit='KiB'>262144</memory>
> > +  <currentMemory unit='KiB'>262144</currentMemory>
> > +  <vcpu placement='static'>8</vcpu>
> > +  <os>
> > +      <type arch='x86_64'>exe</type>
> > +      <init>/sbin/init</init>
> > +  </os>
> > +  <clock offset='utc'/>
> > +  <on_poweroff>destroy</on_poweroff>
> > +  <on_reboot>destroy</on_reboot>
> > +  <on_crash>destroy</on_crash>
> > +  <devices>
> > +    <filesystem type='template'>
> > +        <source name='centos-6-x86_64'/>
> > +        <target dir='/'/>
> > +    </filesystem>
> > +    <video>
> > +      <model type='vga' vram='16777216' heads='1'>
> > +        <acceleration accel3d='no' accel2d='no'/>
> > +      </model>
> > +    </video>
> > +  </devices>
> > +</domain>
> > +
> 
>   That patch has a problem, it doesn't carry the expected code in
> domain parsing but on the other hand include a gnulib version rebase,
> 
>   please fix and repost, I'm keeping your patch 1, 2 and 3 (amended
> with the indentation fix in a local git branch), if you can send me a
> correct 4/4 then i will review and push the set :-)
> 
>  thanks !
> 

Sorry, the parallels_driver.c patch has lost somewhere, I'll sent the corrert
version.

> Daniel
> 
> -- 
> Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
> daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
> http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]