[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv2] build: force libnl1 if netcf also used libnl1



On 09/12/2012 10:46 PM, Osier Yang wrote:
> On 2012年09月11日 06:14, Eric Blake wrote:
>> Recent spec file changes ensure that in distro situations, netcf
>> and libvirt will link against the same libnl in order to avoid
>> dumping core.  But for every-day development, if you are F17 and
>> have the libnl3-devel headers available, libvirt was blindly
>> linking against libnl3 even though F17 netcf still links against
>> libnl1, making testing a self-built binary on F17 impossible.

>> +    case $libnl_ldd:${LIBNL_CFLAGS+set} in
>> +        *libnl.so.1*:) ;;
> 
> The typo ':', as the end of the pattern, causes build failure.

That is NOT a typo.  The case statement is looking at: contents of
$libnl_ldd (which might be empty), followed by a literal :, followed by
the contenst of ${LIBNL_CFLAGS+set} (which will either be empty or the
literal string 'set').  We insist that $libnl_ldd contain libnl.so.1 and
that LIBNL_CFLAGS not be set before we hit this statement.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]