[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 10/20] Fix data types used for list sizes in QEMU capabilities



On Thu, Sep 13, 2012 at 06:12:47AM -0600, Eric Blake wrote:
> On 09/12/2012 10:14 PM, Eric Blake wrote:
> > On 09/11/2012 08:11 AM, Daniel P. Berrange wrote:
> >> From: "Daniel P. Berrange" <berrange redhat com>
> >>
> >> The QEMU capabilities APIs used a misc of 'int' and
> >> 'unsigned int' for variables relating to array sizes.
> >> Change all these to use 'size_t'
> >>
> >> Signed-off-by: Daniel P. Berrange <berrange redhat com>
> >> ---
> >>  src/qemu/qemu_capabilities.c | 22 +++++++++++-----------
> >>  src/qemu/qemu_capabilities.h |  4 ++--
> >>  src/qemu/qemu_command.c      |  2 +-
> >>  src/qemu/qemu_driver.c       |  2 +-
> >>  4 files changed, 15 insertions(+), 15 deletions(-)
> > 
> > Fairly mechanical.
> > ACK.
> 
> Spoke too soon; I'm getting a test coredump:
> TEST: qemuxml2argvtest
>       .../bin/sh: line 5: 19492 Segmentation fault
> abs_top_builddir=`cd '..'; pwd` abs_top_srcdir=`cd '..'; pwd`
> abs_builddir=`pwd` abs_srcdir=`cd '.'; pwd` CONFIG_HEADER="`cd '..';
> pwd`/config.h" PATH="`cd '..'; pwd`/daemon:`cd '..'; pwd`/tools:`cd
> '..'; pwd`/tests:$PATH" SHELL="/bin/sh"
> LIBVIRT_DRIVER_DIR="/home/remote/eblake/libvirt/src/.libs"
> LIBVIRT_AUTOSTART=0 LC_ALL=C ${dir}$tst
> FAIL: qemuxml2argvtest
> 
> but haven't yet takent the time to pin it down.

Hmm, I already pushed this patch & others you ACKd. I ran 'make check'
first and didn't see this crash though.

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]