[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Don't overwrite errors raised by qemuMonitorHMPCommand



On Thu, Sep 13, 2012 at 02:29:50PM +0100, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange redhat com>
> 
> The qemuMonitorHMPCommand() API and things it calls will report
> a wide variety of errors. The QEMU text monitor should not be
> overwriting these errors
> 
> Signed-off-by: Daniel P. Berrange <berrange redhat com>

  ACK,

painful to review, I wish we had semantic patching like coccinelle
ideally we should be able to stack error reports:
  - failed to migrate foo
  - failed to resume foo on target
  - out of memory
i.e. the errors at different layers may all be meaningful in different
ways.

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]