[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Use 'qemu-system-i386' as binary instead of 'qemu'.



On Thu, Sep 13, 2012 at 04:02:17PM +0100, Daniel P. Berrange wrote:
> On Thu, Sep 13, 2012 at 03:51:01PM +0100, Richard W.M. Jones wrote:
> > I have added the attached patch to Fedora because Fedora (only?)
> > renames 'qemu' to 'qemu-system-i386'.  As a result of this, on 32 bit
> > Fedora would run 'qemu-system-x86_64 [...] -cpu qemu32'.
> > 
> > In fact this caused no issues (I originally added the patch because
> > I suspected this was a cause of RHBZ#857026, but that doesn't
> > appear to be the case).  But if we're going to package qemu-system-i386
> > we might as well run it.  The alternative would be to delete that
> > binary altogether if it does nothing useful ...
> > 
> > Rich.
> > 
> > -- 
> > Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
> > virt-p2v converts physical machines to virtual machines.  Boot with a
> > live CD or over the network (PXE) and turn machines into Xen guests.
> > http://et.redhat.com/~rjones/virt-p2v
> 
> > >From 37865f1dead1fac2ee34af48f96d19d686296e04 Mon Sep 17 00:00:00 2001
> > From: "Richard W.M. Jones" <rjones redhat com>
> > Date: Thu, 13 Sep 2012 14:37:22 +0100
> > Subject: [PATCH] Use 'qemu-system-i386' as binary instead of 'qemu'.
> > 
> > ---
> >  src/qemu/qemu_capabilities.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
> > index af3b0b2..179b3d2 100644
> > --- a/src/qemu/qemu_capabilities.c
> > +++ b/src/qemu/qemu_capabilities.c
> > @@ -244,8 +244,8 @@ static const struct qemu_feature_flags const arch_info_x86_64_flags [] = {
> >  
> >  /* The archicture tables for supported QEMU archs */
> >  static const struct qemu_arch_info const arch_info_hvm[] = {
> > -    {  "i686",   32, NULL, "qemu",
> > -       "qemu-system-x86_64", arch_info_i686_flags, 4 },
> > +    {  "i686",   32, NULL, "qemu-system-i386",
> > +       NULL, arch_info_i686_flags, 4 },
> >      {  "x86_64", 64, NULL, "qemu-system-x86_64",
> >         NULL, arch_info_x86_64_flags, 2 },
> >      {  "arm",    32, NULL, "qemu-system-arm",    NULL, NULL, 0 },
> 
> I was going to ACK this, but then it would break libvirt usage with many
> older QEMU versions. Since we generally try to support historic versions
> I'd rather we hold off. I've got a more complete fix which looks for
> the new name, and falls back to the old name.
> 
> https://www.redhat.com/archives/libvir-list/2012-September/msg00662.html

I agree - this (my) patch shouldn't go upstream.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
New in Fedora 11: Fedora Windows cross-compiler. Compile Windows
programs, test, and build Windows installers. Over 70 libraries supprt'd
http://fedoraproject.org/wiki/MinGW http://www.annexia.org/fedora_mingw


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]