[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Look in Debian's multiarch libs too



On Thu, Sep 13, 2012 at 02:35:03PM +0200, =?UTF-8?q?Guido=20G=C3=BCnther?= wrote:
> I checked for libnetcf.so which is in /usr/lib/ but not for libnl1 which
> is already in a multiarch directory (`/usr/lib/i386-linux-gnu/libnl.so).
> So this fixes it:
> 
>  configure.ac |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/configure.ac b/configure.ac
> index b5666a5..dcbe14f 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -2908,7 +2908,7 @@ if test "$with_linux" = "yes"; then
>      # (Setting LIBNL_CFLAGS is already used by PKG_CHECK_MODULES to
>      # override any probing, so if it set, you know which libnl is in use.)
>      libnl_ldd=
> -    for dir in /usr/lib64 /usr/lib; do
> +    for dir in /usr/lib64 /usr/lib /usr/lib/*/libnl.so; do

In fact, what I send in is crap since I need to put a directory here not
the library itself. It turned out that a "git clean -dfx" fixed the
problem too - although I don't know why. Nevertheless the attched patch
would make things more robust since Debian is moving to multiarch [1]
and more and more libs move to /usr/lib/<multiarch-specifier> so we'd be
safe in the future. O.k. to apply the attached version?
Cheers,
 -- Guido

>          if test -f $dir/libnetcf.so; then
>              libnl_ldd=`(ldd $dir/libnetcf.so) 2>&1`
>              break
> -- 
> 1.7.10.4
> 
[1] http://wiki.debian.org/Multiarch/Tuples
>From 2850bf9fc91bd950300fe1ffaa1190cd6d0d1f7e Mon Sep 17 00:00:00 2001
Message-Id: <2850bf9fc91bd950300fe1ffaa1190cd6d0d1f7e 1347550565 git agx sigxcpu org>
From: =?UTF-8?q?Guido=20G=C3=BCnther?= <agx sigxcpu org>
Date: Thu, 13 Sep 2012 14:27:07 +0200
Subject: [PATCH] Look in Debian's multiarch libs too
To: libvir-list redhat com

so we don't fail when libnetcf is built as multiarch lib.
---
 configure.ac |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configure.ac b/configure.ac
index b5666a5..b874971 100644
--- a/configure.ac
+++ b/configure.ac
@@ -2908,7 +2908,7 @@ if test "$with_linux" = "yes"; then
     # (Setting LIBNL_CFLAGS is already used by PKG_CHECK_MODULES to
     # override any probing, so if it set, you know which libnl is in use.)
     libnl_ldd=
-    for dir in /usr/lib64 /usr/lib; do
+    for dir in /usr/lib64 /usr/lib /usr/lib/*-linux-gnu*; do
         if test -f $dir/libnetcf.so; then
             libnl_ldd=`(ldd $dir/libnetcf.so) 2>&1`
             break
-- 
1.7.10.4


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]