[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Look in Debian's multiarch libs too



On 09/13/2012 09:36 AM, Guido Günther wrote:
> On Thu, Sep 13, 2012 at 02:35:03PM +0200, =?UTF-8?q?Guido=20G=C3=BCnther?= wrote:
>> I checked for libnetcf.so which is in /usr/lib/ but not for libnl1 which
>> is already in a multiarch directory (`/usr/lib/i386-linux-gnu/libnl.so).
>> So this fixes it:
>>

>> +    for dir in /usr/lib64 /usr/lib /usr/lib/*/libnl.so; do
> 
> In fact, what I send in is crap since I need to put a directory here not
> the library itself.

Yeah, I was about to point that out, too, until I saw your next email.

At any rate, it looks like you are acking my patch, and I am now acking
yours :)

> It turned out that a "git clean -dfx" fixed the
> problem too - although I don't know why.

I do - because either of our patches in isolation is sufficient to avoid
aborting configure; but my patch in isolation still costs you the time
to probe libnl-3.  Both patches are useful.

> Nevertheless the attched patch
> would make things more robust since Debian is moving to multiarch [1]
> and more and more libs move to /usr/lib/<multiarch-specifier> so we'd be
> safe in the future. O.k. to apply the attached version?

ACK.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]