[libvirt] [PATCH v3 2/9] New functions for virBitmap
Hu Tao
hutao at cn.fujitsu.com
Fri Sep 14 06:22:27 UTC 2012
On Thu, Sep 13, 2012 at 02:35:03PM +0100, Daniel P. Berrange wrote:
> On Thu, Sep 13, 2012 at 02:03:20PM +0800, Hu Tao wrote:
> > In many places we store bitmap info in a chunk of data
> > (pointed to by a char *), and have redundant codes to
> > set/unset bits. This patch extends virBitmap, and convert
> > those codes to use virBitmap in subsequent patches.
> > ---
> > .gitignore | 1 +
> > src/libvirt_private.syms | 11 ++
> > src/util/bitmap.c | 405 +++++++++++++++++++++++++++++++++++++++++++++-
> > src/util/bitmap.h | 34 ++++
> > tests/Makefile.am | 7 +-
> > tests/virbitmaptest.c | 362 +++++++++++++++++++++++++++++++++++++++++
> > 6 files changed, 818 insertions(+), 2 deletions(-)
> > create mode 100644 tests/virbitmaptest.c
> >
> > diff --git a/.gitignore b/.gitignore
> > index d998f0e..1ca537e 100644
> > --- a/.gitignore
> > +++ b/.gitignore
> > @@ -157,6 +157,7 @@
> > /tests/utiltest
> > /tests/viratomictest
> > /tests/virauthconfigtest
> > +/tests/virbitmaptest
> > /tests/virbuftest
> > /tests/virdrivermoduletest
> > /tests/virhashtest
> > diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms
> > index 8dfb4ce..0ad6376 100644
> > --- a/src/libvirt_private.syms
> > +++ b/src/libvirt_private.syms
> > @@ -7,12 +7,23 @@
> >
> > # bitmap.h
> > virBitmapAlloc;
> > +virBitmapAllocFromData;
>
> Hmm, can you rename the existing method 'virBitmapNew' and
> then call you addition 'virBitmapNewData'
OK. I will send v4 to address this.
--
Thanks,
Hu Tao
More information about the libvir-list
mailing list