[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v4 2/9] New functions for virBitmap



On Fri, Sep 14, 2012 at 03:46:57PM +0800, Hu Tao wrote:
> In many places we store bitmap info in a chunk of data
> (pointed to by a char *), and have redundant codes to
> set/unset bits. This patch extends virBitmap, and convert
> those codes to use virBitmap in subsequent patches.
> ---
>  .gitignore               |    1 +
>  src/libvirt_private.syms |   11 ++
>  src/util/bitmap.c        |  405 +++++++++++++++++++++++++++++++++++++++++++++-
>  src/util/bitmap.h        |   34 ++++
>  tests/Makefile.am        |    7 +-
>  tests/virbitmaptest.c    |  362 +++++++++++++++++++++++++++++++++++++++++
>  6 files changed, 818 insertions(+), 2 deletions(-)
>  create mode 100644 tests/virbitmaptest.c

ACK

Top marks for adding a test suite too !

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]