[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/2] build: allow building with newer glibc-headers and -O0



On Fri, Sep 14, 2012 at 11:05:05AM -0600, Eric Blake wrote:
> On 09/12/2012 09:42 AM, Christophe Fergeau wrote:
> > Fix copied from libvirt, commit by Eric Blake.
> > 
> > glibc 2.15 (on Fedora 17) coupled with explicit disabling of
> > optimization during development dies a painful death:
> > 
> > /usr/include/features.h:314:4: error: #warning _FORTIFY_SOURCE requires
> > compiling with optimization (-O) [-Werror=cpp]
> > 
> > Work around this by only conditionally defining _FORTIFY_SOURCE,
> > in the case where glibc can actually use it.  The trick is using
> > AH_VERBATIM instead of AC_DEFINE.
> > ---
> >  m4/virt-compile-warnings.m4 | 8 ++++++--
> >  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> Which project?  Your git config settings didn't identify which repo this
> was for, which was particularly confusing since the same filename exists
> in the libvirt.git repo.

Yes, sorry about that, I missed --subject-prefix when sending this patch.
I've now set it in .git/config. This was a libvirt-designer patch.

Christophe

Attachment: pgp0F0OU6NiVd.pgp
Description: PGP signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]