[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv2 2/9] network: implement RPC calls for virNetworkUpdate



On Tue, Sep 18, 2012 at 03:38:58AM -0400, Laine Stump wrote:
> This is very short, because almost everything is autogenerated. All
> that's needed are:
> 
> * src/remote/remote_driver.c: add pointer to autogenerated
>     remoteNetworkUpdate to the function table for the remote
>     network driver.
> 
> * src/remote/remote_protocol.x: add the "args" struct and add one more
>     item to the remote_procedure enum for this function.
> 
> * src/remote_protocol-struct: update to match remote_protocol.x
> ---
>  src/remote/remote_driver.c   |  1 +
>  src/remote/remote_protocol.x | 12 +++++++++++-
>  src/remote_protocol-structs  |  9 +++++++++
>  3 files changed, 21 insertions(+), 1 deletion(-)
> 
> diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c
> index b6edf38..2f04a32 100644
> --- a/src/remote/remote_driver.c
> +++ b/src/remote/remote_driver.c
> @@ -6076,6 +6076,7 @@ static virNetworkDriver network_driver = {
>      .networkCreateXML = remoteNetworkCreateXML, /* 0.3.0 */
>      .networkDefineXML = remoteNetworkDefineXML, /* 0.3.0 */
>      .networkUndefine = remoteNetworkUndefine, /* 0.3.0 */
> +    .networkUpdate = remoteNetworkUpdate, /* 0.10.2 */
>      .networkCreate = remoteNetworkCreate, /* 0.3.0 */
>      .networkDestroy = remoteNetworkDestroy, /* 0.3.0 */
>      .networkGetXMLDesc = remoteNetworkGetXMLDesc, /* 0.3.0 */
> diff --git a/src/remote/remote_protocol.x b/src/remote/remote_protocol.x
> index 9481f15..4205875 100644
> --- a/src/remote/remote_protocol.x
> +++ b/src/remote/remote_protocol.x
> @@ -1336,6 +1336,15 @@ struct remote_network_undefine_args {
>      remote_nonnull_network net;
>  };
>  
> +struct remote_network_update_args {
> +    remote_nonnull_network net;
> +    unsigned int command;
> +    unsigned int section;
> +    int parentIndex;
> +    remote_nonnull_string xml;
> +    unsigned int flags;
> +};
> +
>  struct remote_network_create_args {
>      remote_nonnull_network net;
>  };
> @@ -2997,8 +3006,9 @@ enum remote_procedure {
>      REMOTE_PROC_CONNECT_LIST_ALL_SECRETS = 287, /* skipgen skipgen priority:high */
>      REMOTE_PROC_NODE_SET_MEMORY_PARAMETERS = 288, /* autogen autogen */
>      REMOTE_PROC_NODE_GET_MEMORY_PARAMETERS = 289, /* skipgen skipgen */
> -    REMOTE_PROC_DOMAIN_BLOCK_COMMIT = 290 /* autogen autogen */
> +    REMOTE_PROC_DOMAIN_BLOCK_COMMIT = 290, /* autogen autogen */
>  
> +    REMOTE_PROC_NETWORK_UPDATE = 291 /* autogen autogen priority:high */
>  
>      /*
>       * Notice how the entries are grouped in sets of 10 ?
> diff --git a/src/remote_protocol-structs b/src/remote_protocol-structs
> index 8b0ae1f..0a9beff 100644
> --- a/src/remote_protocol-structs
> +++ b/src/remote_protocol-structs
> @@ -977,6 +977,14 @@ struct remote_network_define_xml_ret {
>  struct remote_network_undefine_args {
>          remote_nonnull_network     net;
>  };
> +struct remote_network_update_args {
> +        remote_nonnull_network     net;
> +        u_int                      command;
> +        u_int                      section;
> +        int                        index;
> +        remote_nonnull_string      xml;
> +        u_int                      flags;
> +};
>  struct remote_network_create_args {
>          remote_nonnull_network     net;
>  };
> @@ -2406,4 +2414,5 @@ enum remote_procedure {
>          REMOTE_PROC_NODE_SET_MEMORY_PARAMETERS = 288,
>          REMOTE_PROC_NODE_GET_MEMORY_PARAMETERS = 289,
>          REMOTE_PROC_DOMAIN_BLOCK_COMMIT = 290,
> +        REMOTE_PROC_NETWORK_UPDATE = 291,
>  };

  ACK, direct from 1/9

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]