[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 0/4] Add support for reboot-timeout



On 18.09.2012 17:36, Martin Kletzander wrote:
> This series introduces simple reboot timeout support. That means what
> should be done in case all boot options fail, reboot or not. And if
> yes, then how long the machine should wait.
> 
> Before adding the support for that into XML parser, builder, and qemu,
> I felt the need to cleanup the boot parsing and enums (I couldn't look
> at that), so that's the first patch. Most of it is mechanical, the
> rest should be pretty straight-forward.
> ---
> I'd *love* to have it in 0.10.2, but I understand if it's too late :(

I don't feel like the one to make such decision but I'll review the
patches anyway.

> 
> Martin Kletzander (4):
>   qemu: Cleanup boot parameter building
>   Add support for reboot-timeout
>   qemu: Add support for reboot-timeout
>   QEMU Tests for reboot-timeout
> 
>  docs/formatdomain.html.in                          |   9 ++
>  docs/schemas/domaincommon.rng                      |  20 ++++
>  src/conf/domain_conf.c                             |  56 ++++++++-
>  src/conf/domain_conf.h                             |  78 ++++++++-----
>  src/libvirt_private.syms                           |   2 +
>  src/qemu/qemu_capabilities.c                       |   4 +
>  src/qemu/qemu_capabilities.h                       |   1 +
>  src/qemu/qemu_command.c                            | 129 +++++++++++++++++----
>  tests/qemuargv2xmltest.c                           |   4 +
>  ...xml2argv-boot-menu-disable-drive-bootindex.args |   1 +
>  .../qemuxml2argv-reboot-timeout-disabled.args      |   3 +
>  .../qemuxml2argv-reboot-timeout-disabled.xml       |  21 ++++
>  .../qemuxml2argv-reboot-timeout-enabled.args       |   3 +
>  .../qemuxml2argv-reboot-timeout-enabled.xml        |  21 ++++
>  tests/qemuxml2argvtest.c                           |   5 +
>  tests/qemuxml2xmltest.c                            |   4 +
>  16 files changed, 304 insertions(+), 57 deletions(-)
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-reboot-timeout-disabled.args
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-reboot-timeout-disabled.xml
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-reboot-timeout-enabled.args
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-reboot-timeout-enabled.xml
> 
> --
> 1.7.12
> 
> --
> libvir-list mailing list
> libvir-list redhat com
> https://www.redhat.com/mailman/listinfo/libvir-list
> 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]