[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 2/4] Add support for reboot-timeout



On Tue, Sep 18, 2012 at 05:36:47PM +0200, Martin Kletzander wrote:
> Whenever the guest machine fails to boot, new parameter (reboot-timeout)
> controls whether it should reboot and after how many ms it should do so.
> 
> Docs included.
> ---
>  docs/formatdomain.html.in     |  9 +++++++++
>  docs/schemas/domaincommon.rng | 20 ++++++++++++++++++++
>  src/conf/domain_conf.c        | 40 ++++++++++++++++++++++++++++++++++++++++
>  src/conf/domain_conf.h        | 15 +++++++++++++++
>  4 files changed, 84 insertions(+)
> 
> diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
> index 51f897c..b4050cf 100644
> --- a/docs/formatdomain.html.in
> +++ b/docs/formatdomain.html.in
> @@ -106,6 +106,7 @@
>      <bootmenu enable='yes'/>
>      <smbios mode='sysinfo'/>
>      <bios useserial='yes'/>
> +    <reboot-timeout enabled='yes' delay='0'/>

I think it could be a bit misleading to have this element here. To
me it suggests that it applies to OS reboots in general, where as
it only really applies to the BIOS boot. Also having both an 'enabled'
flag and 'delay' attribute is redundant. Surely delay=0 is the default
and any non-zero value signifies it is enabled.

I think I'd prefer to see

  <bootmenu enable='yes|no' rebootDelay='NNN'/>

leave out the rebootDelay attribute when formatting XML if it
is zero

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]