[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] util: don't free dmidecode path string before printing it



On 09/19/2012 05:59 AM, Jiri Denemark wrote:
> On Tue, Sep 18, 2012 at 17:33:57 -0600, Eric Blake wrote:
>> On 09/18/2012 04:57 AM, Ján Tomko wrote:
>>> The path was freed before printing the error message, resulting in:
>>> error : virSysinfoRead:773 : internal error Failed to execute command
>>> (null)
>>> ---
>>>  src/util/sysinfo.c |    2 +-
>>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> While this fixes the bug, it is still a less the useful error.
>> virCommandRun() already gives a better error message and we are
>> overriding it.  I'd prefer:
>>

> Indeed, ACK to this version.

Thanks; pushed.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]