[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv2 5/9] network: reorganize dnsmasq and radvd config file / startup



On 09/18/2012 07:45 PM, Eric Blake wrote:
> On 09/18/2012 01:39 AM, Laine Stump wrote:
>> This patch splits the starting of dnsmasq and radvd into multiple
>> files, and adds new networkRefreshXX() and networkRestartXX()
>> functions for each. These new functions are currently commented out
>> because they won't be used until the next commit, and the compile options
>> require all static functions to be used.
> The other solution to using #if 0 is to instead mark the function
> ATTRIBUTE_UNUSED, so that it will at least compile; then remove the
> attribute in the later patch where you finally use it.

Ah, I didn't realize ATTRIBUTE_UNUSED worked for functions as well (or
maybe I used to know that, and forgot). Much better solution (since you
can then compile the function to make sure it has no errors).


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]