[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/3] Ensure autogen.sh exists if bootstrap fails



On 09/19/2012 12:09 PM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange redhat com>
> 
> If any of the bootstrap tasks (autoconf/automake/etc) failed,
> autogen.sh carried on running any pre-existing configure anyway.
> Use 'set -e' to ensure autogen.sh immediately exists on error.
> ---
>  autogen.sh | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/autogen.sh b/autogen.sh
> index 13df98b..72f1e7a 100755
> --- a/autogen.sh
> +++ b/autogen.sh
> @@ -1,6 +1,8 @@
>  #!/bin/sh
>  # Run this to generate all the initial makefiles, etc.
>  
> +set -e

'set -e' is lousy when mixed with shell functions.  That said, your
approach adds some sanity, even if it is not as much as you think it is
adding, so I'm okay giving this:

weak ACK.

(I'd really rather see us explicitly check for errors after every
command where we care about possible failure, rather than assuming 'set
-e' will behave the way we want it rather than the way POSIX specified
it, but that's a much bigger patch)

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]