[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 01/12] Drop unused return value of virLogOutputFunc



On Thu, Sep 20, 2012 at 08:24:00PM +0200, Miloslav Trmač wrote:
> Nothing uses the return value, and creating it requries otherwise
> unnecessary strlen () calls.
> 
> This cleanup is conceptually independent from the rest of the series
> (although the later patches won't apply without it).  This just seems
> a good opportunity to clean this up, instead of entrenching the unnecessary
> return value in the virLogOutputFunc instance that will be added in this
> series.
> 
> Signed-off-by: Miloslav Trmač <mitr redhat com>
> ---
>  src/util/logging.c | 56 +++++++++++++++++++++++++-----------------------------
>  src/util/logging.h | 14 ++++++--------
>  tests/testutils.c  |  5 ++---
>  3 files changed, 34 insertions(+), 41 deletions(-)

ACK


Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]