[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v3 2/2] Add <seclabel> to character devices.



On Fri, Sep 21, 2012 at 10:52:08AM +0100, Richard W.M. Jones wrote:
> On Fri, Sep 21, 2012 at 11:37:08AM +0200, Michal Privoznik wrote:
> > On 21.09.2012 11:27, Michal Privoznik wrote:
> > > On 20.09.2012 17:29, Richard W.M. Jones wrote:
> > >> From: "Richard W.M. Jones" <rjones redhat com>
> > >>
> > >> This allows the user to control labelling of each character device
> > >> separately (the default is to inherit from the VM).
> > >> ---
> > >>  docs/formatdomain.html.in       |    8 ++++
> > >>  src/conf/domain_conf.c          |   77 +++++++++++++++++++++++++++++++++--
> > >>  src/conf/domain_conf.h          |    6 +++
> > >>  src/security/security_selinux.c |   86 +++++++++++++++++++++++++++------------
> > >>  4 files changed, 147 insertions(+), 30 deletions(-)
> > >>
> > 
> > Ah, I gave premature ACK; you should have updated RNG as well. But I
> > believe you can handle it without any special review. So my ACK holds as
> > long as you update the schema and coding style raised by the first review.
> 
> I'll post an updated version anyway.
> 
> Are there style guidelines on long lines?  I'm seeing a lot of
> long lines in the existing code ..

Informally, 80 characters, but as you see we've not really
enforced it.


Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]