[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] node_memory: Improve the docs



On 2012年09月24日 23:16, Michal Privoznik wrote:
On 24.09.2012 17:10, Osier Yang wrote:
To declare that it's not recommended to use the tuning API while
the outside tuning program (such as ksmtuned under Linux) is running.
---
  src/libvirt.c |    6 ++++++
  1 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/src/libvirt.c b/src/libvirt.c
index 0cbcfbf..43591c0 100644
--- a/src/libvirt.c
+++ b/src/libvirt.c
@@ -6794,6 +6794,12 @@ error:
   * @flags: extra flags; not used yet, so callers should always pass 0
   *
   * Change all or a subset of the node memory tunables.
+ *
+ * Note that it's not recommended to use this function while the
+ * outside tuning program is running (such as ksmtuned under Linux),
+ * as they could change the tunables in parallel, which could cause
+ * conflicts.
+ *
   * This function may require privileged access to the hypervisor.
   *
   * Returns 0 in case of success, -1 in case of failure.


ACK.

Thanks, pushed.


Is there something we can do to protect such behavior meanwhile?


We can prevent the tuning if ksmtuned is running, but not deserved
too much as long as we already have the docment to claim that.

Regards,
Osier


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]