[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v3 02/20] Switch over to use cache for building QEMU capabilities



On 09/25/2012 11:59 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange redhat com>
> 
> When building up a virCapsPtr instance, the QEMU driver
> was copying the list of machine types across from the
> previous virCapsPtr instance, if the QEMU binary had not
> changed. Replace this ad-hoc caching of data with use
> of the new qemuCapsCache global cache.
> 
> Signed-off-by: Daniel P. Berrange <berrange redhat com>
> ---
>  src/conf/capabilities.h      |   1 -
>  src/qemu/qemu_capabilities.c | 228 +++++++++++++------------------------------
>  src/qemu/qemu_capabilities.h |   7 +-
>  src/qemu/qemu_conf.h         |   2 +
>  src/qemu/qemu_driver.c       |  15 +--
>  5 files changed, 84 insertions(+), 169 deletions(-)
> 

ACK.  Nice to see twice as many lines deleted.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]