[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v3 03/20] Remove probing of flags when launching QEMU guests



On 09/25/2012 11:59 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange redhat com>
> 
> Remove all use of the existing APIs for querying QEMU
> capability flags. Instead obtain a qemuCapsPtr object
> from the global cache. This avoids the execution of
> 'qemu -help' (and related commands) when launching new
> guests.
> 
> Signed-off-by: Daniel P. Berrange <berrange redhat com>
> ---
>  src/qemu/qemu_capabilities.c | 92 ++++----------------------------------------
>  src/qemu/qemu_capabilities.h | 11 ++----
>  src/qemu/qemu_command.c      | 85 +++++++++-------------------------------
>  src/qemu/qemu_command.h      |  3 +-
>  src/qemu/qemu_driver.c       | 63 +++++++++++++++++++++---------
>  src/qemu/qemu_process.c      | 21 +++-------
>  tests/qemuxml2argvtest.c     |  4 --
>  tests/qemuxmlnstest.c        |  4 --
>  8 files changed, 81 insertions(+), 202 deletions(-)

Another nice code reduction.

ACK.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]