[libvirt] [PATCH] Fix deadlock in handling EOF in LXC monitor

[Eric Blake]

On 09/26/2012 08:34 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange at redhat.com>
> 
> Depending on the scenario in which LXC containers exit, it is
> possible for the EOF callback of the LXC monitor to deadlock
> the driver. When the driver calls virLXCMonitorClose, there
> is really no need for the EOF callback to be invoked in this
> case, since the caller can easily handle events itself.
> 
> In changing this, the monitor needs to take a deep copy of
> the callback list, not merely a reference.
> 
> Also adds debug statements in various places to aid
> troubleshooting
> 
> Signed-off-by: Daniel P. Berrange <berrange at redhat.com>
> ---
>  src/lxc/lxc_monitor.c | 32 ++++++++++++++++++++++----------
>  src/lxc/lxc_process.c |  6 +++++-
>  2 files changed, 27 insertions(+), 11 deletions(-)
> 

ACK.

-- 
Eric Blake   eblake at redhat.com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 617 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20120926/8b134453/attachment-0001.sig>