[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Fix deadlock in handling EOF in LXC monitor



On 09/26/2012 08:34 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange redhat com>
> 
> Depending on the scenario in which LXC containers exit, it is
> possible for the EOF callback of the LXC monitor to deadlock
> the driver. When the driver calls virLXCMonitorClose, there
> is really no need for the EOF callback to be invoked in this
> case, since the caller can easily handle events itself.
> 
> In changing this, the monitor needs to take a deep copy of
> the callback list, not merely a reference.
> 
> Also adds debug statements in various places to aid
> troubleshooting
> 
> Signed-off-by: Daniel P. Berrange <berrange redhat com>
> ---
>  src/lxc/lxc_monitor.c | 32 ++++++++++++++++++++++----------
>  src/lxc/lxc_process.c |  6 +++++-
>  2 files changed, 27 insertions(+), 11 deletions(-)
> 

ACK.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]