[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v3 17/20] Remove some unused includes in QEMU code



On Tue, Sep 25, 2012 at 19:00:10 +0100, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange redhat com>
> 
> The qemu monitor does not require qemu_conf.h, and the
> qemu capabilities code actually wants bitmap.h
> 
> Signed-off-by: Daniel P. Berrange <berrange redhat com>
> ---
>  src/qemu/qemu_capabilities.c | 2 +-
>  src/qemu/qemu_monitor.c      | 1 -
>  src/qemu/qemu_monitor.h      | 1 -
>  3 files changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
> index c173286..f7ed3e0 100644
> --- a/src/qemu/qemu_capabilities.c
> +++ b/src/qemu/qemu_capabilities.c
> @@ -32,8 +32,8 @@
>  #include "nodeinfo.h"
>  #include "cpu/cpu.h"
>  #include "domain_conf.h"
> -#include "qemu_conf.h"
>  #include "command.h"
> +#include "bitmap.h"
>  #include "virnodesuspend.h"
>  
>  #include <sys/stat.h>
> diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c
> index ca5380b..a5b867c 100644
> --- a/src/qemu/qemu_monitor.c
> +++ b/src/qemu/qemu_monitor.c
> @@ -31,7 +31,6 @@
>  #include "qemu_monitor.h"
>  #include "qemu_monitor_text.h"
>  #include "qemu_monitor_json.h"
> -#include "qemu_conf.h"
>  #include "virterror_internal.h"
>  #include "memory.h"
>  #include "logging.h"
> diff --git a/src/qemu/qemu_monitor.h b/src/qemu/qemu_monitor.h
> index 3e69f64..5762893 100644
> --- a/src/qemu/qemu_monitor.h
> +++ b/src/qemu/qemu_monitor.h
> @@ -29,7 +29,6 @@
>  
>  # include "qemu_capabilities.h"
>  # include "domain_conf.h"
> -# include "qemu_conf.h"
>  # include "bitmap.h"
>  # include "virhash.h"
>  # include "json.h"

I guess you compile-tested :-) ACK

Jirka


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]