[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 3/9] s/int/virLogDestination/ in logging code



On 09/27/2012 10:44 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange redhat com>
> 
> The log destinations are an enum, but most of the code was
> just using a plain 'int' for function params / variables.
> 
> Signed-off-by: Daniel P. Berrange <berrange redhat com>
> ---
>  src/util/logging.c | 4 ++--
>  src/util/logging.h | 2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)

ACK. This time, no testsuite failure, but I'd still suggest squashing
this in before pushing, since '0' is not a valid virLogDestination:

diff --git i/tests/testutils.c w/tests/testutils.c
index a85f560..e144d33 100644
--- i/tests/testutils.c
+++ w/tests/testutils.c
@@ -610,7 +610,7 @@ int virtTestMain(int argc,
     virLogSetFromEnv();
     if (!getenv("LIBVIRT_DEBUG") && !virLogGetNbOutputs()) {
         if (virLogDefineOutput(virtTestLogOutput, virtTestLogClose,
&testLog,
-                               VIR_LOG_DEBUG, 0, NULL, 0) < 0)
+                               VIR_LOG_DEBUG, VIR_LOG_TO_STDERR, NULL,
0) < 0)
             return 1;
     }


-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]