[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] virsh: Add a helper to parse cpulist



On 03/28/2013 05:36 AM, Osier Yang wrote:
> vcpupin and emulatorpin use same code to parse the cpulist, this
> abstracts the same code as a helper. Along with various code style
> fixes, and error improvement (only error "Physical CPU %d doesn't
> exist" if the specified CPU exceed the range, no "cpulist: Invalid
> format", see the following for an example of the error prior to
> this patch).
> 
> % virsh vcpupin 4 0 0-8
> error: Physical CPU 4 doesn't exist.
> error: cpulist: Invalid format.
> ---
>  tools/virsh-domain.c | 278 ++++++++++++++++++++-------------------------------
>  1 file changed, 106 insertions(+), 172 deletions(-)

ACK with your s/vir/vsh/ rename squashed in.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]