[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2] test: Return Libvirt logo as domain screenshot



On 03/31/2013 03:00 AM, Michal Privoznik wrote:
> This is just a bare Easter Egg. Whenever user run virDomainScreenshot

s/user run/a user runs/

> over a domain in test driver, he'll get the Libvirt PNG logo in return.
> ---
>  docs/Makefile.am       |  1 +
>  src/test/test_driver.c | 24 ++++++++++++++++++++++++
>  2 files changed, 25 insertions(+)

Doesn't this also need to touch the libvirt.spec.in file?

What you have looks fine, but I'm reluctant to ack it without knowing
how it fares through a 'make rpm'.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]