[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv3 4/6] virsh: Move cmdConnect from virsh-host.c to virsh.c



On 03/31/2013 10:20 AM, Peter Krempa wrote:
> The function is used to establish connection so it should be in the main
> virsh file. This movement also enables further improvements done in next
> patches.
> ---
>  tools/virsh-host.c | 67 ----------------------------------------------------
>  tools/virsh.c      | 69 ++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 69 insertions(+), 67 deletions(-)

Straightforward code motion; ACK with one nit:

> @@ -3000,6 +3063,12 @@ vshParseArgv(vshControl *ctl, int argc, char **argv)
>  }
> 
>  static const vshCmdDef virshCmds[] = {
> +    {.name = "connect",
> +     .handler = cmdConnect,
> +     .opts = opts_connect,
> +     .info = info_connect,
> +     .flags = VSH_CMD_FLAG_NOCONNECT
> +    },
>      {.name = "cd",

This is not alphabetically sorted.

Also, your commit message might mention that 'connect' has moved from
'virsh help host' into 'virsh help virsh' (I'm okay with that move, but
it IS worth mentioning that it was intentional).

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]