[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v3 1/2] Optimize machine option to set more options with it



On Fri, Mar 29, 2013 at 01:22:46PM +0800, Li Zhang wrote:
> From: Li Zhang <zhlcindy linux vnet ibm com>
> 
> Currently, -machine option is used only when dump-guest-core is set.
> 
> To use options defined in machine option for newer version of QEMU,
> it needs to use -machine xxx, and to be compatible with older version
>  -M, this patch addes QEMU_CAPS_MACHINE_OPT capability for newer
> version which supports -machine option.
> 
> Signed-off-by: Li Zhang <zhlcindy linux vnet ibm com>
> ---
>  v3 -> v2:
>    * Set QEMU_CAPS_MACHINE_OPT with help string
>    * Set QEMU_CAPS_DUMP_GUEST_CORE with QMP
> 
>  v2 -> v1:
>    * Split the patch to 2 parts suggested by Daniel P.Berrange
>    * Rename QEMU_CAPS_MACH_OPT to QEMU_CAPS_MACHINE_OPT
>    * Remove version 1.1 assertion for QEMU_CAPS_MACHINE_OPT
>  
>  src/qemu/qemu_capabilities.c |   11 +++++++++++
>  src/qemu/qemu_capabilities.h |    1 +
>  src/qemu/qemu_command.c      |   32 ++++++++++++++++++--------------
>  tests/qemuhelptest.c         |    4 ++++
>  tests/qemuxml2argvtest.c     |    6 +++---
>  5 files changed, 37 insertions(+), 17 deletions(-)

ACK

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]