[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 2/3] qemu: Error out if the bitmap for pinning is all clear



On 04/02/2013 01:42 AM, Osier Yang wrote:
> For both "live" and "config" changes of vcpupin and emulatorpin, an
> all clear bitmap doesn't make sense, and it can just cause corruptions.
> E.g (similar for emulatorpin).
> 
> % virsh vcpupin hame 0 8,^8 --config
> 
> % virsh vcpupin hame
> VCPU: CPU Affinity
> ----------------------------------
>    0:
>    1: 0-63
>    2: 0-63
>    3: 0-63
> 
> % virsh dumpxml hame |grep cpuset
>     <vcpupin vcpu='0' cpuset=''/>
> 
> % virsh start ham
> error: Failed to start domain hame
> error: An error occurred, but the cause is unknown
> ---
>  src/qemu/qemu_driver.c | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 

ACK - nit - provide the "new" error (also your virsh start line is
missing the 'e' on ham...

John


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]