[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v3] test: Return Libvirt logo as domain screenshot



On Tue, Apr 02, 2013 at 01:52:39PM +0200, Michal Privoznik wrote:
> This is just a bare Easter Egg. Whenever a user runs virDomainScreenshot
> over a domain in test driver, he'll get the Libvirt PNG logo in return.
> ---
>  docs/Makefile.am       |  1 +
>  libvirt.spec.in        |  1 +
>  src/test/test_driver.c | 24 ++++++++++++++++++++++++
>  3 files changed, 26 insertions(+)
> 
> diff --git a/docs/Makefile.am b/docs/Makefile.am
> index 7583772..b5d7575 100644
> --- a/docs/Makefile.am
> +++ b/docs/Makefile.am
> @@ -287,6 +287,7 @@ install-data-local:
>  	for file in $(devhelphtml) $(devhelppng) $(devhelpcss); do \
>  	    $(INSTALL) -m 0644 $(srcdir)/$${file} $(DESTDIR)$(DEVHELP_DIR) ; \
>  	done
> +	$(INSTALL_DATA) $(srcdir)/../docs/libvirtLogo.png $(DESTDIR)$(pkgdatadir)

Huh, with '$(srcdir)' you're in  'docs' already, so why are you doing
'../docs/' ?

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]