[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv2 1/4] virsh: Fix semantics of --config for "update-device" command



On 04/01/13 21:46, Laine Stump wrote:
On 03/31/2013 05:22 PM, Peter Krempa wrote:
The man page states that with --config the next boot is affected. This
can be understood as if _only_ the next boot was affected. This isn't
true if the machine is running.

You should probably change this comment to make it clear that you're
changing the behavior of the option, rather than the documentation of
what it does.

After our discussion last week, I do agree that, although this is a
change in behavior of an already-released command, it's acceptable
because 1) it was different behavior from all other commands using
--config, and 2) it was documented as behaving as all other commands.



This patch adds the full --live, --config, --current infrastructure and
tweaks stuff to correctly support the obsolete --persistent flag.
---

Notes:
     Version 2:
     - note in the docs that semantics of the flags were fixed

ACK once you note in the commit log that the code was fixed, not the
documentation.


I mentioned this in the commit message, removed the stray newline in 3/4 and pushed this with the rest of the series.

Thanks.

Peter


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]