[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Disable static libraries by default



On 04/02/2013 10:09 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange redhat com>
> 
> Every source file is currently built twice by libtool, once for
> the shared library and once for the static library. Static libs
> are not commonly packaged by distros and slow down compilation
> time by as more than 50% compared to a shared-only build time.

s/by as more than/by as much as/

> 
> Time for 'make -j 4':
> 
>       shared only: 2 mins  9 secs
>   shared + static: 3 mins 26 secs
> 
> Time for non-parallel make
> 
>       shared only: 3 mins 32 secs
>   shared + static: 5 mins 41 secs
> 
> Those few people who really want them, can pass --enable-static
> to configure

Yep - we are just altering the defaults, not taking away the capability
altogether.

> 
> Disabling them by default requires use of LT_INIT, but for
> compat with RHEL5 we can't rely on that. So we conditionally
> use LT_INIT, but fallback to AM_PROG_LIBTOOL if not present.
> ---
>  configure.ac | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/configure.ac b/configure.ac
> index 09e4ad9..0df9e5c 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -123,7 +123,11 @@ AC_TYPE_UID_T
>  dnl Support building Win32 DLLs (must appear *before* AM_PROG_LIBTOOL)
>  AC_LIBTOOL_WIN32_DLL
>  
> -AM_PROG_LIBTOOL
> +m4_ifndef([LT_INIT], [
> +  AM_PROG_LIBTOOL
> +], [
> +  LT_INIT([shared disable-static])
> +])

ACK.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]