[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[libvirt] [PATCH 01/16] Free memory on exit, fixes a problem found by coverity.



Signed-off-by: Dan Walsh <dwalsh redhat com>
---
 bin/virt-sandbox-service-util.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/bin/virt-sandbox-service-util.c b/bin/virt-sandbox-service-util.c
index 4d164d8..430518f 100644
--- a/bin/virt-sandbox-service-util.c
+++ b/bin/virt-sandbox-service-util.c
@@ -194,8 +194,8 @@ static int set_process_label(pid_t pid) {
 static int container_execute( GVirSandboxContext *ctx, const gchar *command, pid_t pid ) {
 
     int ret = EXIT_FAILURE;
-    char **argv;
-    int argc;
+    char **argv = NULL;
+    int argc=-1;
 
     if (set_process_label(pid) < 0)
         goto cleanup;
@@ -227,6 +227,10 @@ static int container_execute( GVirSandboxContext *ctx, const gchar *command, pid
     }
 
 cleanup:
+    if (argc > -1)
+            free(argv[0]);
+    free(argv);
+
     return ret;
 }
 
-- 
1.8.2


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]