[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2 01/10] conf: Introduce readonly to hostdev and change helper function



On 04/02/2013 11:02 AM, Han Cheng wrote:
On 04/02/2013 10:15 AM, Hu Tao wrote:
On Mon, Apr 01, 2013 at 08:00:53PM +0800, Han Cheng wrote:
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index f3fca7f..d9d6b9f 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -3452,8 +3452,8 @@ error:
}

int
-virDomainDiskFindControllerModel(virDomainDefPtr def,
- virDomainDiskDefPtr disk,
+virDomainDeviceFindControllerModel(virDomainDefPtr def,
+ virDomainDeviceInfoPtr info,
int controllerType)

Indentation.


I'm sorry for messing this up.
Osier advised me to use virDomainDeviceFindControllerModel rather than
virDomainInfoFindControllerModel. I've change the definition one but I
forgot to change the referenced places. This also caused the indentation
problem.
I didn't pay enough time for this.
I'm really sorry for this.

I'd like to say that I did some test for major object of this patch series.

What I've test:
make && make check.
start and shutdown guest with scsi hostdev.
hotplug/hotunplug scsi hostdev with live guest.

And these all passed.
Sorry for confusion by the code misplacement caused by "git rebase" mistake.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]